Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if dandiset contains zarr assets using asset list endpoint #2170

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

jjnesbitt
Copy link
Member

Closes #2149

This PR adds a simple zarr boolean query param to the /assets endpoint, and updates the client to use that endpoint when checking for zarrs in a dandiset (to prevent publishing of zarrs).

@jjnesbitt jjnesbitt requested a review from waxlamp February 4, 2025 19:51
Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a fix for the typechecking error, this looks good to me!

web/src/views/DandisetLandingView/DandisetPublish.vue Outdated Show resolved Hide resolved
@jjnesbitt jjnesbitt requested a review from waxlamp February 5, 2025 21:28
@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 5, 2025
@jjnesbitt jjnesbitt merged commit e1d436a into master Feb 5, 2025
11 checks passed
@jjnesbitt jjnesbitt deleted the asset-list-zarr-filter branch February 5, 2025 21:40
@dandibot
Copy link
Member

dandibot commented Feb 5, 2025

🚀 PR was released in v0.4.17 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refuses to publish dandiset claiming it has a zarr whenever it (no longer) does
3 participants