Don't WARN about git config returning 1

src/backups2datalad/adataset.py

@@ -182,34 +182,25 @@ async def is_dirty(self) -> bool:
             != ""
         )
 
-    async def get_repo_config(self, key: str) -> str | None:
+    async def get_repo_config(self, key: str, file: str | None = None) -> str | None:
+        args = ["--file", file] if file is not None else []
         try:
-            return await self.read_git("config", "--get", key)
+            return await self.read_git("config", *args, "--get", key, quiet_rcs=[1])
         except subprocess.CalledProcessError as e:
             if e.returncode == 1:
                 return None
             else:
                 raise
 
     async def get_datalad_id(self) -> str:
-        return await self.read_git(
-            "config", "--file", ".datalad/config", "--get", "datalad.dataset.id"
-        )
+        r = await self.get_repo_config("datalad.dataset.id", file=".datalad/config")
+        assert r is not None
+        return r
 
     async def get_embargo_status(self) -> EmbargoStatus:
-        try:
-            value = await self.read_git(
-                "config",
-                "--file",
-                ".datalad/config",
-                "--get",
-                EMBARGO_STATUS_KEY,
-            )
-        except subprocess.CalledProcessError as e:
-            if e.returncode == 1:
-                return EmbargoStatus.OPEN
-            else:
-                raise
+        value = await self.get_repo_config(EMBARGO_STATUS_KEY, file=".datalad/config")
+        if value is None:
+            return EmbargoStatus.OPEN
         else:
             return EmbargoStatus(value)
 

src/backups2datalad/aioutil.py

@@ -5,6 +5,7 @@
     AsyncIterator,
     Awaitable,
     Callable,
+    Collection,
     Container,
     Mapping,
 )
@@ -192,7 +193,7 @@
 
 
 async def aruncmd(
-    *args: str | Path, **kwargs: Any
+    *args: str | Path, quiet_rcs: Collection[int] = (), **kwargs: Any
 ) -> subprocess.CompletedProcess[bytes]:
     argstrs = [str(a) for a in args]
     desc = shlex.join(argstrs)
@@ -204,19 +205,22 @@
     try:
         r = await anyio.run_process(argstrs, **kwargs)
     except subprocess.CalledProcessError as e:
-        label = "Stdout" if e.stderr is not None else "Output"
-        stdout = e.stdout.decode("utf-8", "surrogateescape")
-        if stdout:
-            output = f"{label}:\n\n" + textwrap.indent(stdout, " " * 4)
-        else:
-            output = f"{label}: <empty>"
-        if e.stderr is not None:
-            stderr = e.stderr.decode("utf-8", "surrogateescape")
-            if stderr:
-                output += "\n\nStderr:\n\n" + textwrap.indent(stderr, " " * 4)
+        if e.returncode not in quiet_rcs:
+            label = "Stdout" if e.stderr is not None else "Output"
+            stdout = e.stdout.decode("utf-8", "surrogateescape")
+            if stdout:
+                output = f"{label}:\n\n" + textwrap.indent(stdout, " " * 4)
             else:
-                output += "\n\nStderr: <empty>"
-        log.warning("Failed [rc=%d]: %s\n\n%s", e.returncode, desc, output)
+                output = f"{label}: <empty>"
+            if e.stderr is not None:
+                stderr = e.stderr.decode("utf-8", "surrogateescape")
+                if stderr:
+                    output += "\n\nStderr:\n\n" + textwrap.indent(stderr, " " * 4)
+                else:
+                    output += "\n\nStderr: <empty>"
+            log.warning("Failed [rc=%d]: %s\n\n%s", e.returncode, desc, output)
+        else:
+            log.debug("Finished [rc=%d]: %s", e.returncode, desc)
         raise e
     else:
         log.debug("Finished [rc=%d]: %s", r.returncode, desc)