Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post tagging. #689

Merged
merged 10 commits into from
Feb 7, 2025
Merged

Post tagging. #689

merged 10 commits into from
Feb 7, 2025

Conversation

kernelkind
Copy link
Member

@kernelkind kernelkind commented Feb 3, 2025 •
edited
Loading

closes #131

@kernelkind
Copy link
Member Author

https://v.nostr.build/1mRmAF6CR8cFEw57.mp4

@jb55 jb55 self-assigned this Feb 4, 2025
@jb55 jb55 changed the title Post tagging Post tagging. Feb 4, 2025
@jb55 jb55 removed their assignment Feb 4, 2025
@jb55 jb55 requested review from jb55 and removed request for jb55 February 4, 2025 02:15
@kernelkind kernelkind force-pushed the post_tagging_rebased branch from dd48138 to c3cb6fa Compare February 5, 2025 21:15
@kernelkind
Copy link
Member Author

kernelkind commented Feb 5, 2025 •
edited
Loading

fixed some bugs and now includes coloring mentions in PostView. This required modifications to egui. see 0d7afeb and https://github.com/kernelkind/egui/tree/update_layouter_0.29.1. If you agree with the changes I made, I'll make a PR to egui

@kernelkind kernelkind requested a review from jb55 February 5, 2025 22:05
@jb55
Copy link
Contributor

jb55 commented Feb 6, 2025

needs rebase. looks simple

@kernelkind
supply inner_rect for PostView
9555938 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
add SearchResultsView impl
870d4e9 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
use dev dep pretty assertions
fa189aa 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
mentions logic
2bd8a26 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
add PostView mentions UI
d025870 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
add mention tags to post note
3172871 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
use updated TextEdit::layouter in egui
49fe643 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
implement TextBuffer -> PostBuffer downcasting
82c2f38 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
color mentions in PostView
f6adcd7 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
cache LayoutJob
30cb0b6 
Signed-off-by: kernelkind <[email protected]>
@kernelkind kernelkind force-pushed the post_tagging_rebased branch from 5a4ca53 to 30cb0b6 Compare February 6, 2025 21:20
@kernelkind
Copy link
Member Author

rebased with master

@jb55 Linear
Copy link
Contributor

jb55 commented Feb 7, 2025

can we keep the text color the same? it looks like it changed

@alltheseas alltheseas mentioned this pull request Feb 7, 2025
Open
@jb55 jb55 merged commit 62ee726 into damus-io:master Feb 7, 2025
8 checks passed
@jb55
Copy link
Contributor

jb55 commented Feb 7, 2025

this was an accidental merge... might need to re-open this

@kernelkind kernelkind mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
None yet
Projects
Damus Roadmap 🛣️
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post tagging
2 participants
@kernelkind @jb55