Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assorted relay problems #665

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

ksedgwic
Copy link
Contributor

Includes the following (mostly independent) fixes:

  • Use the current selected account only to determine desired relays. Previously the desired relay list was determined from the union of all accounts.
  • Update the relay configuration immediately when the user switches accounts.
  • Delete relays from the account (instead of the relay pool directly). This results in the relay being removed in the pool as well, but is persisted correctly.

@jb55
Copy link
Contributor

jb55 commented Jan 23, 2025

I started reviewing this patch-by-patch and realized the patch I was reviewing was completely rewritten. let's squash

- Use the current selected account only to determine desired
  relays. Previously the desired relay list was determined from the
  union of all accounts.
- Update the relay configuration immediately when the user switches accounts.
- Delete relays from the account (instead of the relay pool
  directly). This results in the relay being removed in the pool as
  well, but is persisted correctly.
@ksedgwic ksedgwic force-pushed the 2025-01-relay-fixes branch from 3c9fdc7 to 1e0801f Compare January 24, 2025 00:09
@ksedgwic
Copy link
Contributor Author

squashed

@jb55 jb55 merged commit 0c3db9a into damus-io:master Jan 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants