Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload images #662

Merged
merged 8 commits into from
Jan 26, 2025
Merged

Upload images #662

merged 8 commits into from
Jan 26, 2025

Conversation

kernelkind
Copy link
Member

closes: #168

@kernelkind kernelkind requested a review from jb55 January 22, 2025 20:17
crates/notedeck_columns/src/post.rs Outdated Show resolved Hide resolved
crates/notedeck_columns/src/post.rs Outdated Show resolved Hide resolved
crates/notedeck_columns/src/media_upload.rs Outdated Show resolved Hide resolved
@jb55
Copy link
Contributor

jb55 commented Jan 23, 2025 via email

@jb55
Copy link
Contributor

jb55 commented Jan 23, 2025 via email

@jb55
Copy link
Contributor

jb55 commented Jan 23, 2025

man I hate github reviews. gotta start a nip34 notedeck app soon

@kernelkind
Copy link
Member Author

Kind of sucks we're moving further away from android portability which I wanted to launch soon. I guess we need some code to disable this on android for now?

Yeah I conditionally use rfd to select media for desktop here but I can also add the condition to only compile rfd for those same targets.

I can add a way to select files for android next

@kernelkind
Copy link
Member Author

kernelkind commented Jan 24, 2025

diff --git a/crates/notedeck_columns/Cargo.toml b/crates/notedeck_columns/Cargo.toml
index 69ee1b5..ae8a4eb 100644
--- a/crates/notedeck_columns/Cargo.toml
+++ b/crates/notedeck_columns/Cargo.toml
@@ -46,7 +46,7 @@ uuid = { workspace = true }
 sha2 = { workspace = true }
 base64 = { workspace = true }

-#[cfg(any(target_os = "windows", target_os = "macos", target_os = "linux"))]
+[target.'cfg(any(target_os = "windows", target_os = "macos", target_os = "linux"))'.dependencies]
 rfd = "0.15"

 [dev-dependencies]

and rebased with master

@jb55 jb55 merged commit 6dd0e52 into damus-io:master Jan 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload single image to Nostr Build
3 participants