Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take an iterator of &str in Filter::tags #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Take an iterator of &str in Filter::tags #38

wants to merge 2 commits into from

Conversation

yukibtc
Copy link
Contributor

@yukibtc yukibtc commented Jan 29, 2025

Take an iterator of &str instead of String in Filter::tags.

In a separated commit (776b722), I also removed tracing-subscriber dep since it was unused.

@jb55
Copy link
Contributor

jb55 commented Jan 31, 2025 via email

@jb55 jb55 linked an issue Feb 4, 2025 that may be closed by this pull request
Take an iterator of &str in Filter::tags #40
Open
@jb55 jb55 self-requested a review February 4, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take an iterator of &str in Filter::tags
2 participants
@yukibtc @jb55