Add AWS S3 backend #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-barluzzi
force-pushed
the
s3
branch
2 times, most recently
from
8270e62 to
e82a172
Compare
daknob
requested changes
Oct 18, 2017
| @_wrap_aws_exception | ||
| def does_paste_exist(paste_id): | ||
| try: | ||
| _s3.Object(_bucket, paste_id).load() |
There was a problem hiding this comment.
I assume the load() function will actually download the paste content. If there a different function to check whether a specific key exists? If not, load() is fine, but may cause double or triple downloads of the paste from the server.
There was a problem hiding this comment.
This should be fine. The documentation isn't entirely clear, but Object.load should just do a minimal (HEAD) request to check if the object exists. Object.get, on the other hand, will do a full (GET) request to download the object's contents.
|
Thanks for another great backend service! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a storage backend based on Amazon AWS S3 storage system. See #15
The AWS S3 storage system allows us to treat:
pasteas an Amazon S3objectpast_idas an objectkey(or key name)metadataas an objectmetadata(which is accessible in a limited way, and which cannot be merely modified)You find more information regarding Amazon S3 objects and their data, key, and metadata here.
Due to the lack of options, this PR does not implement any preventive approach for each communication with the Amazon S3 storage (e.g. setting a timeout).
This should be merged after #66 so that unrelated lint errors are fixed.
Pair-programmed with @c-w