Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #51

Merged
merged 15 commits into from
Oct 19, 2016
Merged

Refactor code #51

merged 15 commits into from
Oct 19, 2016

Conversation

daknob
Copy link
Owner

@daknob daknob commented Oct 15, 2016

A new file called logic.py has been created whose purpose is to include all application logic. This file will then be used by torpaste.py to make all decisions in the HTTP level using Flask.

@daknob
Copy link
Owner Author

daknob commented Oct 15, 2016

@j11e I am proposing these changes, which may unfortunately break Pull Request #49 . If you like these changes, let me know, so we can find a solution. This is just a heads up. I think it will clean up the codebase a lot, and will help in fixing issue #19 which I will be working on after I finish with this.

@daknob
Copy link
Owner Author

daknob commented Oct 15, 2016

BTW, we probably have to come up with a smarter system than the multiple returns in order to convey messages to torpaste.py. Exceptions sure can be one of them, however I did not implement them for simplicity. Will probably do this soon, definitely before merging.

@j11e
Copy link
Contributor

j11e commented Oct 16, 2016

I was away this week-end, I'll take a look tomorrow. No worries about the pull request anyway, I'll just rebase.

@j11e
Copy link
Contributor

j11e commented Oct 18, 2016

I'm ok with the changes. Fun fact: I was thinking of moving the configuration handling code in another file, considering how fast the number of supported variables is increasing. You moved out the other part of the code first :)

@daknob
Copy link
Owner Author

daknob commented Oct 18, 2016

Thanks! So yes, I moved the other part as well and I am also considering moving the configuration code, but I have not done this yet. Give me some time to work on this PR a little bit more, and if everything is okay, I'll merge it and then work on Exceptions. You can work on moving the config file if you'd like.. :-)

@daknob daknob changed the title [WIP] Refactor code Refactor code Oct 19, 2016
@daknob daknob merged commit 8067d9b into master Oct 19, 2016
@daknob daknob deleted the feature/code-refactor branch November 13, 2016 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants