Skip to content

Commit

Permalink
Remove math topic from displayed information (#97)
Browse files Browse the repository at this point in the history
This does not affect the underlying data but in the future we can remove that too.
  • Loading branch information
marisademeglio committed Nov 7, 2024
1 parent 129ee8c commit 71d51ff
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 5 deletions.
29 changes: 28 additions & 1 deletion src/pages/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ p.message {
}
/* list with columns e.g. reinvite users page */
ul.cols {
columns: 3;
columns: 2;
}

/* participage page */
Expand Down Expand Up @@ -369,4 +369,31 @@ p.latest-testbook {
.info-note {
font-style: italic;
font-size: smaller;
}

/* TODO remove this when math is removed at the data level */
/* this just disables the display of math entries */
#results-table thead th:nth-of-type(7) {
display: none;
}
#results-table tbody tr td:nth-of-type(7) {
display: none;
}
.secondary-nav li:has(a[href='#math']) {
display: none;
}
section:has(h3[id='math']) {
display: none;
}
#test-books-table tr:has(a[href='/test-books/math']) {
display: none;
}
#testing-environment-details tr[id='math-1.1.1'] {
display: none;
}
.dashboard-topics tr[class='math'] {
display: none;
}
ul.topics li:has(a[href='/results/topic/math']) {
display: none;
}
4 changes: 2 additions & 2 deletions src/pages/templates/dashboard-details.njk
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
{{ testingEnvironmentDetails.TestingEnvironmentDetails(testingEnvironment) }}
<div id="table-controls" class="table-controls"></div>
<div role="region" aria-labelledby="table-caption-{{testingEnvironment.id}}" tabindex="0">
<table aria-live="polite" aria-colcount="4" aria-rowcount="{{testingEnvironment.answerSets.length}}" id="answer-sets-{{testingEnvironment.id}}">
<table class="dashboard-topics" aria-live="polite" aria-colcount="4" aria-rowcount="{{testingEnvironment.answerSets.length}}" id="answer-sets-{{testingEnvironment.id}}">
<caption id="table-caption-{{testingEnvironment.id}}">
Topics tested for {{testingEnvironmentLabels.TestingEnvironmentOneLinerPlainText(testingEnvironment)}}
</caption>
Expand All @@ -44,7 +44,7 @@
<tbody>
{%- for answerSet in testingEnvironment.answerSets -%}
{%- set answerSetStatus = displayUtils.answerSetCompletedStatus(answerSet) -%}
<tr id="a{{answerSet.id}}">
<tr id="a{{answerSet.id}}" class="{{answerSet.testBook.topic.id}}">
<td>
<span class="{{answerSetStatus.class}}">{{answerSetStatus.message}}</span>
</td>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/templates/participate.njk
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

<p>This will bring you to the testing page. There, you will see a link to download the <span class="cmd">test book</span> itself (the EPUB file). Download the book and open it in the reading system that you're testing.</p>

<p class="note">A <span class="cmd">test book</span> is a custom EPUB containing the tests for a topic. For example, there are test books for Math, Visual Adjustments, Media Overlays, and many more reading system testing topics. Using a consistent set of test books increases the accuracy of the testing experience report.</p>
<p class="note">A <span class="cmd">test book</span> is a custom EPUB containing the tests for a topic. For example, there are test books for Visual Adjustments, Media Overlays, and many more reading system testing topics. Using a consistent set of test books increases the accuracy of the testing experience report.</p>

<p>For each test in the book, there is a corresponding row on the testing page form. Follow the instructions in the book and record an answer for each test.</p>

Expand Down
2 changes: 1 addition & 1 deletion src/pages/templates/results.njk
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<h2>Results</h2>
<div>
<p>See all results on this page or explore further by topic:</p>
<ul class="cols">
<ul class="cols topics">
{%- for topic in topics -%}
<li><a href="/results/topic/{{topic.id}}">{{topicNames.TopicName(topic.id)}}</a></li>
{%- endfor -%}
Expand Down

0 comments on commit 71d51ff

Please sign in to comment.