Increased min hole size 0.2mm to use seeed fab. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just an update, we have assembled these PCB and the work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Daniel. This is both a pull request (if you're interested) and sanity check. You used a lot of 7mil drill vias on your boards. This is just under what Seeed Fusion PCB allows at 0.2mm min drill diameter. Seeed is amazing: I can get 10 of your boards with ENIG 4mil trace/space for 60 dollars. Its amazing resource for people who want to build things on their own. I increased the drill sizes of small vias to fit their tolerances. I ran a DRC using their rules, but since you designed the board, you may notice things that won't work. Can you give these changes a quick sanity check?
Anyway, if you want to reject the PR that's fine, I just wanted to make these changes pubic in case they are beneficial to you. Alternatively, you could cherry pick the gerbers and leave the board design unchanged.
I've treated the DAQ board in the same way and I'll submit a PR for that too.