[pythonic resources] never treat partial resources as resolved #27210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2025
benpankow
force-pushed
the
benpankow/never-treat-partial-resources-as-resolved
branch
from
6c37b38 to
e19c5ee
Compare
dpeng817
reviewed
Jan 21, 2025
| @@ -965,3 +965,64 @@ def my_asset(outer: MyBoringOuterResource) -> str: | |||
| "my_asset", | |||
| "SetupTeardownInnerResource yield_for_execution done", | |||
| ] | |||
|
|
|||
|
|
|||
| def test_nested_resources_runtime_config_fully_populated() -> None: | |||
There was a problem hiding this comment.
describe test case in docstring pls
dpeng817
reviewed
Jan 21, 2025
Comment on lines
971
to
981
| class CredentialsResource(ConfigurableResource): | ||
| username: str = "default_username" | ||
| password: str = "default_password" | ||
|
|
||
| class DBConfigResource(ConfigurableResource): | ||
| creds: CredentialsResource | ||
| host: str = "default_host" | ||
| database: str = "default_database" | ||
|
|
||
| class DBResource(ConfigurableResource): | ||
| config: DBConfigResource |
There was a problem hiding this comment.
nit: I think it would be a bit more clear to make the names reference what we're testing (IE top level resource, nested resource, further nested resource etc
benpankow
force-pushed
the
benpankow/never-treat-partial-resources-as-resolved
branch
from
e19c5ee to
ef85376
Compare
benpankow
changed the base branch from
benpankow/pythonic-config-nesting-defaults-2
to
master
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit ef85376. |
benpankow
deleted the
benpankow/never-treat-partial-resources-as-resolved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The implementation of
_is_fully_configuredpreviously would mark partial/configure-at-runtime resources as fully populated if all values had defaults. This means the config values couldn't be overridden at runtime properly.This PR ensures that partial/configure-at-runtime resources can always have fields overridden at runtime.
Test Plan
Previously failing unit test.