[docs] add docs for PipesEMRContainersClient #27159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgafni
changed the title
danielgafni
force-pushed
the
01-16-_docs_add_docs_for_pipesemrcontainers
branch
2 times, most recently
from
aa0ea18 to
19c94d2
Compare
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-2glwctjpf-elementl.vercel.app Direct link to changed pages: |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Yeah, the new file looks correct to me too -- I wonder if your recent changes aren't showing up because there are merge conflicts, since I'm also not seeing your updates to dagster-pipes.mdx in the preview. Just as a heads up, we're moving to a new docs platform this Thursday, so future docs changes should be made to the files in docs_beta/docs. The new Pipes docs live in docs_beta/docs/guides/build/external-pipelines/. |
neverett
approved these changes
Jan 21, 2025
|
Alright! Thanks! |
danielgafni
force-pushed
the
01-16-_docs_add_docs_for_pipesemrcontainers
branch
2 times, most recently
from
ef07531 to
420f265
Compare
danielgafni
force-pushed
the
01-16-_docs_add_docs_for_pipesemrcontainers
branch
from
420f265 to
5a51e2b
Compare
alangenfeld
pushed a commit
that referenced
this pull request
Jan 23, 2025
## Summary & Motivation This PR adds docs for the new PipesEMRContainersCient. It sounds confusing but AWS EMR Containers and AWS EMR on EKS is actually the same thing. The former is the name of the AWS API, and the latter is the service name (sounds like the same thing huh?) which is more used in human language rather than automation. For example, the `boto3` client is called `emr-containers`. I tried to preserve this differentiation in these docs. ## How I Tested These Changes The snippets were tested with a real EMR on EKS cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR adds docs for the new PipesEMRContainersCient.
It sounds confusing but AWS EMR Containers and AWS EMR on EKS is actually the same thing.
The former is the name of the AWS API, and the latter is the service name (sounds like the same thing huh?) which is more used in human language rather than automation.
For example, the
boto3client is calledemr-containers.I tried to preserve this differentiation in these docs.
How I Tested These Changes
The snippets were tested with a real EMR on EKS cluster.