Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Open evaluation detail dialog from automaterialize tag #26963

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Jan 9, 2025

Summary & Motivation

Fix "View evaluation" links from AutomaterializeTagWithEvaluation, which shows asset keys and evaluation links in a popover, e.g. on a Run. When clicking the link, open the evaluation detail dialog.

Additionally:

  • Added the asset (or asset check) information in a tag in the dialog header, because otherwise it's not clear what asset you're looking at.
  • Added a footer button to link to the asset's Automation tab, cursored to the currently viewed evaluation ID. This is to allow a look at recent history.

How I Tested These Changes

View a run that has this tag. Verify that the popover link opens the dialog correctly, and that the asset tag renders in the header.

Changelog

[ui] Open the evaluation detail dialog from the "Automation condition" tag popover on Runs.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hellendag hellendag force-pushed the 01-08-_ui_open_evaluation_detail_dialog_from_automaterialize_tag branch from 862046c to 0b416dc Compare January 9, 2025 03:10
@hellendag hellendag marked this pull request as ready for review January 9, 2025 03:11
Copy link
Member Author

hellendag commented Jan 9, 2025

Merge activity

  • Jan 9, 9:33 AM CST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 9, 9:33 AM CST: A user merged this pull request with Graphite.

@hellendag hellendag merged commit 9a8a7e9 into master Jan 9, 2025
1 of 2 checks passed
@hellendag hellendag deleted the 01-08-_ui_open_evaluation_detail_dialog_from_automaterialize_tag branch January 9, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants