Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide for setting environment variables in Dagster+ UI #24012

Merged

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Aug 28, 2024

Summary & Motivation

Guide for setting env vars in the Dagster+ UI. Largely pulled from the existing guide

How I Tested These Changes

Changelog [New | Bug | Docs]

NOCHANGELOG

Copy link
Contributor Author

jamiedemaria commented Aug 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jamiedemaria and the rest of your teammates on Graphite Graphite

@jamiedemaria jamiedemaria force-pushed the jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui branch from 974a04b to 280ec21 Compare August 28, 2024 16:05

## How to set different values for environment variables in different deployment environments
You can create multiple instances of the same environment variable key with different values. This allows you to provide different values to different deployment environments. For example, you may want to use different Snowflake credentials for your production deployment than in branch deployments.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section feels a bit wordy to me. i'm going to revisit it in an hour or so

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It honestly doesn't seem to bad to me

@jamiedemaria jamiedemaria marked this pull request as ready for review August 28, 2024 16:11
@graphite-app graphite-app bot added area: docs Related to documentation in general docathon labels Aug 28, 2024
Copy link

graphite-app bot commented Aug 28, 2024

Graphite Automations

"docs-beta - Assign Reviewers" took an action on this PR • (08/28/24)

1 label was added and 3 reviewers were added to this PR based on Pedram Navid's automation.

@jamiedemaria jamiedemaria force-pushed the jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui branch from 280ec21 to 7278887 Compare August 28, 2024 16:18
## How to set different values for environment variables in different deployment environments
You can create multiple instances of the same environment variable key with different values. This allows you to provide different values to different deployment environments. For example, you may want to use different Snowflake credentials for your production deployment than in branch deployments.

When you [add an environment variable](#how-to-add-an-environment-variable) you can select the deployment scope and code location scope for the environment variable. You can create multiple environment variables with different values and different scopes to customize the values in different deployment environments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be just repeating the previous paragraph though

Copy link
Contributor

@PedramNavid PedramNavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Once the docs are deployed, let me know and I can give it a second look

Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still thinking on the last section of this guide, but wanted to put up the rest of my comments first. I'll add more in a little bit.

@jamiedemaria jamiedemaria force-pushed the jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui branch from 6438a93 to d5cefa2 Compare August 28, 2024 17:57
@jamiedemaria jamiedemaria force-pushed the jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui branch from d5cefa2 to 5395e14 Compare August 28, 2024 18:26
@jamiedemaria
Copy link
Contributor Author

@jamiedemaria
Copy link
Contributor Author

@erinkcochran87 @PedramNavid or @cmpadden who should the technical reviewer of this be?

@jamiedemaria jamiedemaria force-pushed the jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui branch from 5395e14 to 8f910be Compare August 29, 2024 16:20
@erinkcochran87
Copy link
Contributor

@jamiedemaria I was able to step through everything in the UI with these instructions, so I think we're good here. I'm going to do a quick cleanup and then I'll merge this for ya.

@erinkcochran87 erinkcochran87 merged commit 5ffa931 into master Aug 29, 2024
2 of 4 checks passed
@erinkcochran87 erinkcochran87 deleted the jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui branch August 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general docathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants