-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide for setting environment variables in Dagster+ UI #24012
Guide for setting environment variables in Dagster+ UI #24012
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on Graphite |
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-chuuolq66-elementl.vercel.app Direct link to changed pages:
|
974a04b
to
280ec21
Compare
|
||
## How to set different values for environment variables in different deployment environments | ||
You can create multiple instances of the same environment variable key with different values. This allows you to provide different values to different deployment environments. For example, you may want to use different Snowflake credentials for your production deployment than in branch deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section feels a bit wordy to me. i'm going to revisit it in an hour or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It honestly doesn't seem to bad to me
Graphite Automations"docs-beta - Assign Reviewers" took an action on this PR • (08/28/24)1 label was added and 3 reviewers were added to this PR based on Pedram Navid's automation. |
280ec21
to
7278887
Compare
## How to set different values for environment variables in different deployment environments | ||
You can create multiple instances of the same environment variable key with different values. This allows you to provide different values to different deployment environments. For example, you may want to use different Snowflake credentials for your production deployment than in branch deployments. | ||
|
||
When you [add an environment variable](#how-to-add-an-environment-variable) you can select the deployment scope and code location scope for the environment variable. You can create multiple environment variables with different values and different scopes to customize the values in different deployment environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be just repeating the previous paragraph though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Once the docs are deployed, let me know and I can give it a second look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still thinking on the last section of this guide, but wanted to put up the rest of my comments first. I'll add more in a little bit.
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
docs/docs-beta/docs/dagster-plus/deployment/environment-variables/dagster-ui.md
Outdated
Show resolved
Hide resolved
6438a93
to
d5cefa2
Compare
d5cefa2
to
5395e14
Compare
@erinkcochran87 @PedramNavid or @cmpadden who should the technical reviewer of this be? |
5395e14
to
8f910be
Compare
@jamiedemaria I was able to step through everything in the UI with these instructions, so I think we're good here. I'm going to do a quick cleanup and then I'll merge this for ya. |
…i' of https://github.com/dagster-io/dagster into jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui
…i' of https://github.com/dagster-io/dagster into jamie/doc-410-refresh-setting-env-vars-in-the-dagster-ui
Summary & Motivation
Guide for setting env vars in the Dagster+ UI. Largely pulled from the existing guide
How I Tested These Changes
Changelog [New | Bug | Docs]
NOCHANGELOG