Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 return the missing debub log message when loading partitions with PolarsDeltaIOManager #21651

Merged

Conversation

danielgafni
Copy link
Contributor

Summary & Motivation

This log message was accidentally removed in my last dagster-polars PR. Fixing this.

How I Tested These Changes

@garethbrickman garethbrickman added the integration: polars Related to dagster-polars label May 6, 2024
@garethbrickman
Copy link
Contributor

@danielgafni Ah circled back round to this one and I see the build failed. I think you'll need to merge master back into this branch so it's caught up and then re-run ruff

@danielgafni
Copy link
Contributor Author

Yep I know, unfortunately, my dev setup is broken right now + I'm moving right now, so might take a while to do it

@danielgafni
Copy link
Contributor Author

@garethbrickman I'm back! :)

@garethbrickman
Copy link
Contributor

@danielgafni

FAILED dagster_polars_tests/test_deltalake.py::test_polars_delta_io - TypeError: dataframe contains unsupported data types: {Null}
--
FAILED dagster_polars_tests/test_polars_delta.py::test_polars_delta_io_manager - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value

@danielgafni
Copy link
Contributor Author

Uhh, probably a polars update... will take a look

@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label Jun 18, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 June 18, 2024 13:33
@danielgafni danielgafni force-pushed the danielgafni/fix-polarsdelta-logs branch from ed16ad2 to 20a44f7 Compare June 18, 2024 14:29
@danielgafni
Copy link
Contributor Author

Apologies for the wrong label, I messed up git. The label can be removed now.

@danielgafni
Copy link
Contributor Author

Tests passing locally

@garethbrickman garethbrickman removed the area: dagster-university Related to Dagster University label Jun 18, 2024
@garethbrickman garethbrickman merged commit 466bd9f into dagster-io:master Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: polars Related to dagster-polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants