Skip to content

Commit

Permalink
[docs] handle multi-redirects for dagster plus; misc fixes (#27323)
Browse files Browse the repository at this point in the history
## Summary & Motivation

## How I Tested These Changes

## Changelog

NOCHANGELOG
  • Loading branch information
cmpadden authored Jan 23, 2025
1 parent 92ffc2d commit aeb88d5
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 25 deletions.
21 changes: 11 additions & 10 deletions .github/workflows/build-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,23 @@ name: Deploy Docs
on:
push:
branches:
- master
- "release-*" # older verions of the docs
- docs-prod # prod
paths:
- docs/**
- "!docs/docs-beta/**" # Exclude docs-beta
- examples/docs_snippets/**
- CHANGES.md
- .github/workflows/build-docs.yml
pull_request:
# - master
# - "release-*" # older verions of the docs
# - docs-prod # prod
- "legacy-docs-release-*" # older verions of the docs
paths:
- docs/**
- "!docs/docs-beta/**" # Exclude docs-beta
- examples/docs_snippets/**
- CHANGES.md
- .github/workflows/build-docs.yml
# pull_request:
# paths:
# - docs/**
# - "!docs/docs-beta/**" # Exclude docs-beta
# - examples/docs_snippets/**
# - CHANGES.md
# - .github/workflows/build-docs.yml
concurrency:
# Cancel in-progress runs on same branch
group: ${{ github.workflow}}-${{github.ref}}
Expand Down
14 changes: 7 additions & 7 deletions docs/docs-beta/docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const config: Config = {
},
announcementBar: {
id: 'announcementBar',
content: `<div><h3>Welcome to Dagster's new and improved documentation site!</h3> You can find the legacy documentation with content for versions 1.9.8 and earlier at <a target="_blank" href="https://legacy-docs.dagster.io/">legacy-docs.dagster.io</a>.</div>`,
content: `<div><h3>Welcome to Dagster's new and improved documentation site!</h3> You can find the legacy documentation with content for versions 1.9.9 and earlier at <a target="_blank" href="https://legacy-docs.dagster.io/">legacy-docs.dagster.io</a>.</div>`,
},
colorMode: {
defaultMode: 'light',
Expand Down Expand Up @@ -112,12 +112,12 @@ const config: Config = {
// docId: 'changelog',
// position: 'right',
//},
{
label: 'Feedback',
href: 'https://github.com/dagster-io/dagster/discussions/24816',
position: 'right',
className: 'feedback-nav-link',
},
// {
// label: 'Feedback',
// href: 'https://github.com/dagster-io/dagster/discussions/24816',
// position: 'right',
// className: 'feedback-nav-link',
// },
],
},
image: 'img/docusaurus-social-card.jpg',
Expand Down
11 changes: 3 additions & 8 deletions docs/docs-beta/vercel.json
Original file line number Diff line number Diff line change
Expand Up @@ -361,22 +361,17 @@
"permanent": false
},
{
"source": "/dagster-cloud",
"destination": "/dagster-plus/",
"permanent": false
},
{
"source": "/dagster-cloud/managing-deployments/setting-up-alerts",
"source": "/dagster-plus/managing-deployments/setting-up-alerts",
"destination": "/dagster-plus/features/alerts/",
"permanent": false
},
{
"source": "/dagster-cloud/managing-deployments/dagster-cloud-cli",
"source": "/dagster-plus/managing-deployments/dagster-cloud-cli",
"destination": "/dagster-plus/deployment/management/dagster-cloud-cli/",
"permanent": false
},
{
"source": "/dagster-cloud/developing-testing/code-locations",
"source": "/dagster-plus/developing-testing/code-locations",
"destination": "/dagster-plus/deployment/code-locations/",
"permanent": false
},
Expand Down

1 comment on commit aeb88d5

@github-actions
Copy link

@github-actions github-actions bot commented on aeb88d5 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-jd1n3qeoj-elementl.vercel.app

Built with commit aeb88d5.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.