-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce
kinds
backed by asset spec tags (#23779)
## Summary Introduces a `kinds` property to `AssetSpec`, a set of strings representing compute, storage etc kinds, based on dagster-io/internal#10821 (comment). These kinds are backed by specially constructed tags of the form `dagster/kind/python`, `dagster/kind/snowflake` which canonically have empty `""` values. Right now, we expect these tags to be only set by internal Dagster code (e.g. integrations). A subsequent, stacked PR (#24154) introduces a top-level `kinds` parameter, which is immediately converted to this special tag format. ## Test Plan Unit tests.
- Loading branch information
Showing
15 changed files
with
659 additions
and
265 deletions.
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
9327529
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-hcdvjlpdh-elementl.vercel.app
Built with commit 9327529.
This pull request is being automatically deployed with vercel-action