Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[1.8.0][config] change who gets mypy errors from pydantic 2 to pydant…
…ic 1 users (#22527) context #17443, specifically > Unless someone is able to find a clever solution it appears the only choice is to flip who gets the errors at some point. looking at [pypi download stats](https://www.pepy.tech/projects/pydantic?versions=2.*&versions=1.*) pydantic 2 downloads are ballpark 30% more than pydantic 1 so opening this PR to discuss if now / `1.8.0` is the time ## How I Tested These Changes run `mypy` on ``` from dagster import Config class MyConfig(Config): ... ``` pydantic 2: no error pydantic 1: `error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]` (cherry picked from commit f15a9fd)
- Loading branch information
0f546d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-e5jtbvc1n-elementl.vercel.app
https://release-1-8.dagster.dagster-docs.io
Built with commit 0f546d6.
This pull request is being automatically deployed with vercel-action