Remove warnings in forall #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method makes it difficult to use the libraries in a project that enables `--enforce-determinism`.
robin-aws
approved these changes
Aug 20, 2024
atomb
approved these changes
Aug 20, 2024
robin-aws
added a commit
to dafny-lang/dafny
that referenced
this pull request
Mar 4, 2025
…6137) ### What was changed? Build the standard libraries with `enforce-determinism = true` in general, so consumers can use that option too. This is especially important now since it turns out Rust code generation requires this option. This was blocked by the non-deterministic `var x :| x in s;` statement in `Seq.SetToSeq`, so I've also removed that just as we did previously from `dafny-lang/libraries`: dafny-lang/libraries#158 (review). Unfortunately a breaking change, but done in the name of soundness, and the implementation was O(n^2) and not suitable for most production use anyway. ### How has this been tested? Also updated standard libraries tests to specify `enforce-determinism = true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are still using this.
Need to move over to the DafnyStandardLibrary, but that is not compiled with
utf8-falseyet.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.