better error handling

src/send-feed.ts

@@ -39,8 +39,9 @@ class SendFeed {
 
 
   async summarizeResources(resources: ResourceI[]) {
+    const newResources: ResourceI[] = [];
+
     try {
-      const newResources: ResourceI[] = [];
       for (const resource of resources) {
         resource.readLength = readingTime(resource.content || resource.description || "").text
         if ((!resource.summary || resource.summary.length < 100) && (resource.content || resource.description)) {
@@ -52,14 +53,16 @@ class SendFeed {
         }
         newResources.push(resource)
       }
-
-      return newResources;
     } catch (err) {
       // Handle errors with summarizing, allowing it to fail silently 
       // so users can still get the digests without summarization
       console.error("Something went wrong with summarizing", err);
     } finally {
-      return resources;
+      // check if newResources is the same length as resources
+      // if it isn't, it means something must have gotten when setting summaries
+      // in new resources, hence return resources
+
+      return newResources.length === resources.length ? newResources : resources;
     }
   }
 
@@ -180,4 +183,4 @@ class SendFeed {
   }
 };
 
-export default SendFeed;
+export default SendFeed;

src/utils/email/generateEmailTemplate.ts

@@ -1,4 +1,5 @@
 import { ResourceI } from "../constants.js";
+import { handleContentOrDescription } from "../preprocessing.js";
 import moment from 'moment';
 const generatePost = (post: ResourceI, isSummaryEnabled: boolean) => `
 <table style="font-family:trebuchet ms,geneva;" role="presentation" cellpadding="0" cellspacing="0" width="100%" border="0">
@@ -26,8 +27,8 @@ const generatePost = (post: ResourceI, isSummaryEnabled: boolean) => `
     ? post?.summary[0] === ":"
       ? "Summary" + post.summary
       : "Summary: " + post.summary
-    : (post.content || post.description)
-    : (post.content || post.description)}</p>
+    : handleContentOrDescription(post.content || "", post.description || "")
+    : handleContentOrDescription(post.content || "", post.description || "")}</p>
         </div>
       </td>
     </tr>

src/utils/preprocessing.ts

@@ -51,3 +51,16 @@ export const cleanHTMLContent = (str: string) => {
 
   return content;
 };
+
+export const handleContentOrDescription = (content: string, description: string): string => {
+  let result: string
+  if (content && description) {
+    result = content.length < description.length ? content : description;
+  } else if (content) {
+    result =  content;
+  } else {
+    result = description;
+  }
+
+  return result.substring(0, 25);
+}

src/utils/summarize.ts

@@ -35,7 +35,8 @@ export class Summarizer {
 
       return response?.data?.choices[0]?.text?.trim() || "";
     } catch (err) {
-      console.error("Error summarizing: ", err)
+      console.warn("Error summarizing: ", err);
+      return "";
     }
   }