Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Update functions for plotting variants (4/P) #53

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

AntoniaChroni
Copy link
Contributor

Purpose/implementation Section

What scientific question is your analysis addressing?

To create functions to generate plots for variants: overall, per cancer group, and per kids_id.

What was your approach?

What GitHub issue does your pull request address?

This is related to the #41

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please review for code logic.

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link

@naqvia naqvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function works as intended. Look good to me! Approving

@AntoniaChroni AntoniaChroni merged commit 62e0854 into main Dec 14, 2023
@AntoniaChroni AntoniaChroni deleted the achroni/update-barplots-function branch December 14, 2023 23:29
AntoniaChroni added a commit that referenced this pull request Jan 24, 2024
Update functions for plotting variants (4/P)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants