-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Co-authored-by: Ryan Corbett <[email protected]>
Co-authored-by: Ryan Corbett <[email protected]>
@rjcorb The following is to address the question asked about intercepts in #20. ''The intercepts here were used to differentiate clonal from subclonal gene mutations. So, it is okay if the However, after discussing with @jharenza, we decided to also address the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I really like the look of the correlation plots. I did notice that, in some cases, the labels don't seem to be aligning with points on the plot. For example, in PT_MDWPRDBT-Recurrence_BS_00TRPEQX-vs-Deceased_BS_1M63B97V-vaf-corplot.pdf
, it is not clear which variants the labels correspond to. The colors also seem to not match with positions on the plot. Like in that example, shouldn't blue text point to blue points?
@rjcorb The labels can't be positioned exactly on the points on the plot. I tried to draw connecting lines that would label specific points on a plot, but with no lack. I was ending up having them in all the points. :( |
Have you tried |
Yes, I tried multiple times and it was drawing all lines instead. |
@AntoniaChroni ah I see. I will approve since this only seems to be an issue for a few plots. But since some plots have many overlapping labels that make them difficult to read, maybe you could filter points that get labeled based on a VAF threshold? |
…rplots Create corplots-PR-v2
Purpose/implementation Section
What scientific question is your analysis addressing?
This is a script written to create corplots for patient cases with multiple biospecimen samples and matched longitudinal samples.
What was your approach?
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please review for script logic.
Is there anything that you want to discuss further?
The input file
maf_autopsy.tsv
is generated from the tmb-vaf-preprocess data (2/N) #16 and is placed in../../scratch
. Please run that script first to ensure that you have all files necessary.This is a PR based on the previous #20 that was closed by accident.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes.
Results
What types of results are included (e.g., table, figure)?
There are 139 plots generated based on every combination between
Kids_First_Biospecimen_ID/tumor_descriptor/Kids_First_Participant_ID
and are placed in../../plots
.Please check if that is the number of plots generated. For easier visualization and going through the results, please see the html report.
What is your summary of the results?
There are 29 autopsy samples out of the total 119 patient cases (with genomic assays) with maf information. There are 117 (out of the 118) patient samples with TMB information. There are 44 biospecimen samples missing from both TMB and VAF files.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.