This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR updates the dockerfile to R 4.4.0 and uses BioC 3.19 to source any R packages not on GitHub so that they are compatible with R 4.4.0
What was your approach?
Updated dockerfile and pushed to CAVATICA at
pgc-images.sbgenomics.com/d3b-bixu/pbta-ancestry:latest
What GitHub issue does your pull request address?
Closes #69
Directions for reviewers. Tell potential reviewers what kind of feedback you are
soliciting.
Which areas should receive a particularly close look?
There is one script
03-plot-survival.R
with an error, due to astr_replace
in the plotting function:Is there anything that you want to discuss further?
Yes, we should make sure we fix the plotting issue - pull using:
docker pull pgc-images.sbgenomics.com/d3b-bixu/pbta-ancestry:latest
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are
ready for review?
yes
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
project Dockerfile.
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up todate.