Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Update survival plots number formatting (4/N) #67

Merged
merged 5 commits into from
May 13, 2024

Conversation

rjcorb
Copy link
Contributor

@rjcorb rjcorb commented Apr 17, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are

soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are

ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the
    project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to
    date.
  • The analytical code is documented and contains comments.

@rjcorb rjcorb changed the title Update survival plots number formatting Update survival plots number formatting (4/N) Apr 17, 2024
@rjcorb rjcorb requested review from jharenza and naqvia April 30, 2024 20:37
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates, however, had a few issues.

  1. Your FP pdfs in braf-fusions do not match mine when I rerun - I still see 3 or varied decimals in the plots. This is whether I run the script 03 or full module.
    UPDATE: I see those changes over here.
  2. When re-running survival module script 03 alone, it throws an error:
Rscript --vanilla 03-plot-survival.R 
-- Attaching core tidyverse packages -------------------------------------------------------------------------------------------------------- tidyverse 2.0.0 --
v dplyr     1.1.4     v readr     2.1.5
v forcats   1.0.0     v stringr   1.5.1
v ggplot2   3.5.1     v tibble    3.2.1
v lubridate 1.9.3     v tidyr     1.3.1
v purrr     1.0.2     
-- Conflicts -------------------------------------------------------------------------------------------------------------------------- tidyverse_conflicts() --
x dplyr::filter() masks stats::filter()
x dplyr::lag()    masks stats::lag()
i Use the conflicted package (<http://conflicted.r-lib.org/>) to force all conflicts to become errors
Loading required package: colorspace
Loading required package: ggpubr

Attaching package: 'survminer'

The following object is masked from 'package:survival':

    myeloma

Rows: 1484 Columns: 41
-- Column specification ----------------------------------------------------------------------------------------------------------------------------------------
Delimiter: "\t"
chr (22): Kids_First_Biospecimen_ID, predicted_ancestry, Kids_First_Particip...
dbl (18): EAS_prob, AFR_prob, AMR_prob, SAS_prob, EUR_prob, PC1, PC2, PC3, P...
lgl  (1): given_ancestry

i Use `spec()` to retrieve the full column specification for this data.
i Specify the column types or set `show_col_types = FALSE` to quiet this message.
Error in readRDS(con, refhook = refhook) : cannot open the connection
Calls: read_rds -> readRDS
In addition: Warning message:
In readRDS(con, refhook = refhook) :
  cannot open file '/home/rstudio/pbta-ancestry/analyses/survival/results/ATRT/logrank_ATRT_OS_predicted_ancestry.RDS': No such file or directory

However, when I run the whole module, it completes and the changes are as expected. So I suggest you rerun the full modules and commit all changes- maybe something got removed by accident.

Base automatically changed from rjcorb/62-update-cohort to main May 8, 2024 14:09
@rjcorb
Copy link
Contributor Author

rjcorb commented May 8, 2024

ok, I've rerun and committed all RDS files. Let me know if that resolves the issue.

@rjcorb rjcorb requested a review from jharenza May 8, 2024 15:00
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming the survival module plots are now correct here, but once this is merged and then merged into 68, 68 will need a rerun since the plots here will have 3 decimals for braf fusions but in 68 they have two. merging 67 into 68 will put them back at 3....

Copy link

@naqvia naqvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code runs and plots generated!

@rjcorb rjcorb merged commit 0ec3ddb into main May 13, 2024
@rjcorb rjcorb deleted the rjcorb/65-format-survival-numbers branch May 13, 2024 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants