Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Add module to assess demographic and clinical summary stats by predicted ancestry #54

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

rjcorb
Copy link
Contributor

@rjcorb rjcorb commented Feb 12, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are

soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are

ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the
    project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to
    date.
  • The analytical code is documented and contains comments.

Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no openxlsx in the docker file, and can you please add a run script to the demo-clin-stats module?

Otherwise, this runs once installed and the simulated p values are very similar, as expected.

@rjcorb rjcorb changed the base branch from rjcorb/docker-openxlsx to main February 29, 2024 14:27
@rjcorb rjcorb merged commit a6ae544 into main Feb 29, 2024
1 check passed
@rjcorb rjcorb deleted the rjcorb/49-demo-clin-stats branch February 29, 2024 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants