This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Multiplexing into syslog #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesos master and slave daemon attempt to multiplex stdout and stderr into info and crit syslog severities, but it does not work properly and forwards all log output into err severity only. Use first character of each log message to distinguish its severity and multiplex them into appropriate syslog severities. This fixes #15. The multiplexing also removes timestamp from log message as syslog would add its own and having two timestamps would make logs unreadable.
Mesos binaries calls EXIT(1) with message when encountering critical error. Error conditions logged by EXIT call do not go into default log files in /var/log/mesos at all. When binary runs as daemon, they may get lost completely. Enhance log multiplexing to match all messages that do not conform to logging pattern and forward them to syslog as critical errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submitting fix for multiplexing mesos-slave and mesos-master console output into syslog.
The patch multiplexes all log messages with [IWEF] prefix into appropriate syslog priorities.
Now it also correctly forwards error messages with no prefix into crit syslog priority.