*8785* Adapt tasks interface and add names

cziaarm · May 4, 2015 · 9f163ef · 9f163ef
1 parent 71de6e1
commit 9f163ef
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 3 deletions.
diff --git a/classes/tasks/OpenAccessNotification.inc.php b/classes/tasks/OpenAccessNotification.inc.php
@@ -24,6 +24,13 @@ function OpenAccessNotification() {
 		$this->ScheduledTask();
 	}
 
+	/**
+	 * @see ScheduledTask::getName()
+	 */
+	function getName() {
+		return __('admin.scheduledTask.openAccessNotification');
+	}
+
 	function sendNotification ($users, $journal, $issue) {
 		if ($users->getCount() != 0) {
 
@@ -91,7 +98,10 @@ function sendNotifications ($journal, $curDate) {
 		}
 	}
 
-	function execute() {
+	/**
+	 * @see ScheduledTaks::executeActions()
+	 */
+	protected function executeActions() {
 		$journalDao = DAORegistry::getDAO('JournalDAO');
 		$journals = $journalDao->getAll(true);
 

diff --git a/classes/tasks/ReviewReminder.inc.php b/classes/tasks/ReviewReminder.inc.php
@@ -24,6 +24,13 @@ function ReviewReminder() {
 		$this->ScheduledTask();
 	}
 
+	/**
+	 * @see ScheduledTask::getName()
+	 */
+	function getName() {
+		return __('admin.scheduledTask.reviewReminder');
+	}
+
 	function sendReminder ($reviewAssignment, $submission, $context) {
 		$reviewAssignmentDao = DAORegistry::getDAO('ReviewAssignmentDAO');
 		$userDao = DAORegistry::getDAO('UserDAO');
@@ -85,7 +92,10 @@ function sendReminder ($reviewAssignment, $submission, $context) {
 
 	}
 
-	function execute() {
+	/**
+	 * @see ScheduledTask::executeActions()
+	 */
+	protected function executeActions() {
 		$submission = null;
 		$context = null;
 

diff --git a/classes/tasks/SubscriptionExpiryReminder.inc.php b/classes/tasks/SubscriptionExpiryReminder.inc.php
@@ -24,6 +24,13 @@ function SubscriptionExpiryReminder() {
 		$this->ScheduledTask();
 	}
 
+	/**
+	 * @see ScheduledTask::getName()
+	 */
+	function getName() {
+		return __('admin.scheduledTask.subscriptionExpiryReminder');
+	}
+
 	function sendReminder ($subscription, $journal, $emailKey) {
 
 		$userDao = DAORegistry::getDAO('UserDAO');
@@ -214,7 +221,10 @@ function sendJournalReminders ($journal, $curDate) {
 		}
 	}
 
-	function execute() {
+	/**
+	 * @see ScheduledTask::executeActions()
+	 */
+	protected function executeActions() {
 		$journalDao = DAORegistry::getDAO('JournalDAO');
 		$journals = $journalDao->getAll(true);