Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential bug: RAD_HOME in linux #173

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

potential bug: RAD_HOME in linux #173

wants to merge 58 commits into from

Conversation

QZera
Copy link
Collaborator

@QZera QZera commented Jan 26, 2025 •
edited
Loading

Temporary PR to run some CI jobs. To be deleted once the bug at hand has been confirmed/debunked.

QZera added 30 commits January 26, 2025 12:08
@QZera
test(temp): delete non e2e workflows
ada05f0 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(temp): remove macos from e2e workflow
9f6cee9 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): add initial test for path to rad binary setting
5a16bbd 
- adds test/e2e/helpers/actions.ts and test/e2e/helpers/queries.ts and extracts 2 helper
functions
- adds new test/e2e/specs/settings.spec.ts suite and implements initial test
- sets order of suites to:
  1. onboarding (sequential)
  2. rest of the settings (parallel)

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): test recognition when directory is created after the setti…
8b8269e 
…ng is updated

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): simplify settings.spec.ts
958a36b 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): increase pause before updating setting to 5s
2eb8249 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
revert: "test(debug): increase pause before updating setting to 5s"
7683552 
This reverts commit a7a9179.

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): open radicle view container before initial assertion
af7d49c 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: open radicle view container *after* changing input value (works…
97ab6d6 
… on both platforms!)

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: hoist variables outside of test case, in describe
1e17797 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
revert: "test: hoist variables outside of test case, in describe"
cf97cd7 
This reverts commit a397eb9.

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: update not found assertion interval to .5s and timeout to 20s
f786db6 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: add todo to fine-tune timeouts and intervals
37fcc82 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
revert: ""revert: hoist variables outside of test case, in describe""
f712dc3 
This reverts commit b9358c2.

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: add case for entering a valid path
5ea225b 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: increase timeout and decrease interval on cli and patches asser…
cc67ac5 
…tion

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: clear setting input before updating it
8e02f89 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: remove pauses before updating input value
c9a6a0d 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test: log input value before clearing it
5838d68 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): imrpove helper functions for manipulating settings
54613c3 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): remove TextSetting import in favor of Setting
8fc5080 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): add test for recognizing directory after updating setting
da2b6d9 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): skip directory creation recognition case
214f57a 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): close radicle view container after onboarding suite
189c95d 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): move worbench and settings init to a before statement
7b62e7b 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): open radicle view container before running settings suite
da9564b 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): add describe statement for path to rad binary setting
ff85bd7 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): add after each statement
640aecf 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): move initial state assertion to top level before statement
5136bf6 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): move initial assertion after opening settings
0f19c41 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
QZera added 25 commits January 26, 2025 12:08
@QZera
test(e2e): use chainable promises in settings.spec.ts
02d18a9 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
chore(e2e): fix rebase ts errors
f774ec3 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): remove pause before updating input
a7272e9 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
revert: "test(e2e): remove pause before updating input"
dafb965 
This reverts commit b927a0c.

Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): write draft for initial path to node home test
ca3a0e2 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): clear output and join text before asserting error
81971e0 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
refactor(e2e): fix rebase error
127f195 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): do not re-select outputview
82c966b 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): do not select radicle channel on output view
98b135e 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): clear settings searchbox after first describe
b9fcf69 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): remove empty input assertion
5ab76f2 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): copy after statement to path to node home setting
76abf32 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): move findSetting to before statement
975ff4a 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): remove browser pause before setting input value
1f10c51 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): refactor waitUntil statement
c325d82 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): clear setting input and wait for output update
0d99066 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): log joined text
a1690c8 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): skip first settings suite
bb63f2b 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): skip all settings suite
c66b63f 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): verify httpd is recognized in ubuntu
317fff0 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): don't clear output
127bad1 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): write new suite to verify httpd
b89175c 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): manually set node home path to RAD_HOMe
816b4b8 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(debug): log rad self
f229415 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera
test(e2e): delete settings.spec.ts
e5f133d 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera QZera force-pushed the temp/linux-node-home-bug branch from c9aec09 to e5f133d Compare January 26, 2025 10:09
@QZera QZera changed the title potential bug: linux node home recognition potential bug: RAD_HOME in linux Jan 26, 2025
@QZera
test(debug): cleanup
57bf3f0 
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
@QZera QZera mentioned this pull request Jan 26, 2025
Open
@maninak
Copy link
Collaborator

maninak commented Jan 29, 2025

Looks like it may not be a bug in the extension but in the testing code's expectations instead.
Related: #167 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QZera @maninak