Fix build without libical #5208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compile errors "'libical/ical.h' file not found" in various places when built on a system without libical installed. Probably broken by cyrusimap#3467, cyrusimap#3815, cyrusimap#3845. Signed-off-by: Christian Walther <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building cyrus-imapd on a system that does not have libical installed (with iCal features accordingly disabled by
configure) fails with a compiler error'libical/ical.h' file not foundin various places. Checked on macOS (15.2) and Linux (Ubuntu 20.04).This appears to have been broken when #3467, #3815, #3845 started including code that was previously exclusive to CalDAV features also when CalDAV is disabled. It was presumably not noticed when testing only on systems that do have libical installed, even with CalDAV explicitly disabled.
I can fix this with the
#ifdefsadded in the attached commit, but am not sure whether these are exactly the right macros to test.