Sieve: allow private Final-Recipient in rejects, allow non-Original-Recipient header for original recipient. #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbs
force-pushed
the
cyr-1422-private-mdn
branch
from
894b2ad to
a04620e
Compare
|
Shouldn't merge until v3.12 forked. Will require tweak to Fm internal builds. |
|
lgtm, but I think we also need a changes/next/* entry? Like b48001d |
wolfsage
approved these changes
Dec 9, 2024
Great catch, thank you. |
wolfsage
reviewed
Dec 10, 2024
elliefm
approved these changes
Dec 10, 2024
I'll add the Do Not Merge label so it (hopefully) doesn't get merged accidentally |
rjbs
force-pushed
the
cyr-1422-private-mdn
branch
from
cca019d to
969f7a8
Compare
rjbs
force-pushed
the
cyr-1422-private-mdn
branch
from
969f7a8 to
631cb1e
Compare
This replaces a longstanding private commit in Fastmail's Cyrus, which replaces Final-Recipient with an encrypted version of the original recipient. The goal is to provide a string that can be traced back to a recipient by the Cyrus operator, but doesn't disclose the final delivery username to the bounce recipient. Using session_id should accomplish the same result, at least if logs are maintained. It's also a lot less complex than shipping our own little RC4 implementation!
rjbs
force-pushed
the
cyr-1422-private-mdn
branch
from
631cb1e to
2bddca9
Compare
rjbs
changed the title
rjbs
force-pushed
the
cyr-1422-private-mdn
branch
2 times, most recently
from
f69efad to
a976fab
Compare
wolfsage
requested changes
Dec 16, 2024
This eliminates custom code in Fastmail builds.
rjbs
force-pushed
the
cyr-1422-private-mdn
branch
from
a976fab to
649c4ee
Compare
wolfsage
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a longstanding private commit in Fastmail's Cyrus, which replaces Final-Recipient with an encrypted version of the original recipient. The goal is to provide a string that can be traced back to a recipient by the Cyrus operator, but doesn't disclose the final delivery username to the bounce recipient.
Using session_id should accomplish the same result, at least if logs are maintained. It's also a lot less complex than shipping our own little RC4 implementation!
This then replaces another private commit, allowing the Sieve rejection code to pluck the original recipient from a header other than Original-Recipient.