fix(other): display commited date instead of the pull request creation date #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baraka24
force-pushed
the
fix-server-info-commit_date
branch
from
fe144a8 to
0df86ee
Compare
Baraka24
changed the title
kroky
reviewed
Jan 7, 2025
| * @return string The commit date | ||
| */ | ||
| protected function getCommitDate($commit_hash) { | ||
| $command = 'git log -1 --format=%cd ' . escapeshellarg($commit_hash); |
There was a problem hiding this comment.
Cypht might not have a local git repo - there are other distribution channels than git pull... see Hm_Handler_process_server_info for more info on how it gets commit hash and tries to get the date from github API endpoint. I think you should change that class rather than add more code here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Issues
Todo