InetAddr: Use onion addresses instead of public keys #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCharlatan
force-pushed
the
torInet
branch
from
f646f26 to
bd2fd6a
Compare
Define new Tor enum inner types for the `InetAddr` `PartialSocketAddr`, and `InetSocketAddr` types. Replace the usage of the `TorPublicKeyV3` with `OnionAddressV3`. While the two types are interchangeable, `OnionAddressV3` is the human-readable format. For encoding purposes, `OnionAddressV3` is converted to `TorPublicKeyV3` in order to save some space. Additionally, adds port numbers to the `PartialSocketAddr` and `InetSocketAddr` tor variants. This allows users to specify a specific port on which an onion address is listening.
TheCharlatan
force-pushed
the
torInet
branch
from
bd2fd6a to
e4b68e1
Compare
|
I have recently discovered that the whole design I have in Please have a look there and let me know what do you think. Example usage can be found here: https://github.com/Internet2-WG/rust-netservices/blob/master/nsh/src/main.rs Specifically, this piece uses the address system: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR to discuss the format of the Tor address variants. This change reflects how I would reason about them. I'm curious what the original reasoning behind the design of the type was. If there is another / better approach to this, I'm very open to implement that instead.
Define new Tor enum inner types for the
InetAddrPartialSocketAddr, andInetSocketAddrtypes. Replace the usage of theTorPublicKeyV3withOnionAddressV3. While the two types are interchangeable,OnionAddressV3is the human-readable format. For encoding purposes,OnionAddressV3is converted toTorPublicKeyV3in order to save some space.Additionally, adds port numbers to the
PartialSocketAddrandInetSocketAddrtor variants. This allows users to specify a specific port on which an onion address is listening.