fix(autoware_obstacle_stop_planner): fix passedByValue (autowarefound…

…ation#8189) fix:passedByValue Signed-off-by: kobayu858 <[email protected]>
cyn-liu · Aug 2, 2024 · f105db9 · f105db9
1 parent b00e8e9
commit f105db9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.cpp b/planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.cpp
@@ -748,7 +748,7 @@ void AdaptiveCruiseController::registerQueToVelocity(
   est_vel_que_.emplace_back(new_vel);
 }
 
-double AdaptiveCruiseController::getMedianVel(const std::vector<nav_msgs::msg::Odometry> vel_que)
+double AdaptiveCruiseController::getMedianVel(const std::vector<nav_msgs::msg::Odometry> & vel_que)
 {
   if (vel_que.size() == 0) {
     RCLCPP_WARN_STREAM(node_->get_logger(), "size of vel que is 0. Something has wrong.");

diff --git a/planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.hpp b/planning/autoware_obstacle_stop_planner/src/adaptive_cruise_control.hpp
@@ -183,7 +183,7 @@ class AdaptiveCruiseController
   };
   Param param_;
 
-  double getMedianVel(const std::vector<nav_msgs::msg::Odometry> vel_que);
+  double getMedianVel(const std::vector<nav_msgs::msg::Odometry> & vel_que);
   double lowpass_filter(const double current_value, const double prev_value, const double gain);
   void calcDistanceToNearestPointOnPath(
     const TrajectoryPoints & trajectory, const int nearest_point_idx,

diff --git a/planning/autoware_obstacle_stop_planner/src/planner_utils.cpp b/planning/autoware_obstacle_stop_planner/src/planner_utils.cpp
@@ -228,7 +228,7 @@ std::string jsonDumpsPose(const Pose & pose)
   return json_dumps_pose;
 }
 
-DiagnosticStatus makeStopReasonDiag(const std::string stop_reason, const Pose & stop_pose)
+DiagnosticStatus makeStopReasonDiag(const std::string & stop_reason, const Pose & stop_pose)
 {
   DiagnosticStatus stop_reason_diag;
   KeyValue stop_reason_diag_kv;

diff --git a/planning/autoware_obstacle_stop_planner/src/planner_utils.hpp b/planning/autoware_obstacle_stop_planner/src/planner_utils.hpp
@@ -122,7 +122,7 @@ Polygon2d convertBoundingBoxObjectToGeometryPolygon(
 
 std::string jsonDumpsPose(const Pose & pose);
 
-DiagnosticStatus makeStopReasonDiag(const std::string stop_reason, const Pose & stop_pose);
+DiagnosticStatus makeStopReasonDiag(const std::string & stop_reason, const Pose & stop_pose);
 
 TrajectoryPoint getBackwardPointFromBasePoint(
   const TrajectoryPoint & p_from, const TrajectoryPoint & p_to, const TrajectoryPoint & p_base,