Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output consistency check when there are offsets. #6526

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Fix output consistency check when there are offsets. #6526

merged 9 commits into from
Dec 17, 2024

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Dec 16, 2024 •
edited
Loading

Close #6523

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added the bug Something is wrong :( label Dec 16, 2024
@hjoliver hjoliver added this to the 8.4.0 milestone Dec 16, 2024
@hjoliver hjoliver requested a review from wxtim December 16, 2024 03:05
@hjoliver hjoliver self-assigned this Dec 16, 2024
@hjoliver hjoliver force-pushed the fix-graph-offset-opt branch 3 times, most recently from 0cb877a to 811699f Compare December 16, 2024 03:35
@hjoliver hjoliver force-pushed the fix-graph-offset-opt branch from 811699f to 691f6f5 Compare December 16, 2024 03:41
@hjoliver hjoliver force-pushed the fix-graph-offset-opt branch from 691f6f5 to b0ec142 Compare December 16, 2024 04:32
@hjoliver hjoliver force-pushed the fix-graph-offset-opt branch from f3592ef to 697f923 Compare December 16, 2024 04:51
@hjoliver hjoliver marked this pull request as ready for review December 16, 2024 05:13
wxtim
wxtim reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to double check the test I've queried, but otherwise this seems to fix the bug in question.

I have a related issue where some code I did early in the year hasn't caused a bug, but I'm unclear whether it's correct. 😢

tests/integration/reftests/test_pre_initial.py Show resolved Hide resolved
cylc/flow/graph_parser.py Outdated Show resolved Hide resolved
tests/unit/test_graph_parser.py Outdated Show resolved Hide resolved
@wxtim wxtim mentioned this pull request Dec 16, 2024
Closed
8 tasks
@markgrahamdawson markgrahamdawson merged commit d4edafa into cylc:master Dec 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgrahamdawson markgrahamdawson markgrahamdawson approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@hjoliver hjoliver

Labels
bug Something is wrong :(
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

Graph: Inter-cycle dependencies not correctly checked
3 participants
@hjoliver @markgrahamdawson @wxtim