Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc set corrections #795

Merged
merged 2 commits into from
Feb 10, 2025
Merged

cylc set corrections #795

merged 2 commits into from
Feb 10, 2025

Conversation

MetRonnie
Copy link
Member

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@MetRonnie MetRonnie added content Addition or modification of documentation small labels Feb 4, 2025
@MetRonnie MetRonnie added this to the 8.4.0 milestone Feb 4, 2025
@MetRonnie MetRonnie self-assigned this Feb 4, 2025
@MetRonnie MetRonnie requested a review from wxtim February 4, 2025 16:25
@MetRonnie
Copy link
Member Author

Juts linkcheck failing and I CBA to keep re-running it

wxtim
wxtim approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good: Merge or request 2nd review.

@oliver-sanders oliver-sanders requested review from hjoliver and removed request for oliver-sanders February 10, 2025 09:47
hjoliver
hjoliver approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@hjoliver hjoliver merged commit e1ae078 into cylc:master Feb 10, 2025
1 check passed
@MetRonnie MetRonnie deleted the cylc-set branch February 11, 2025 09:57
@MetRonnie MetRonnie restored the cylc-set branch February 18, 2025 10:43
@MetRonnie MetRonnie mentioned this pull request Feb 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@MetRonnie MetRonnie

Labels
content Addition or modification of documentation small
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @hjoliver @wxtim