-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for trigger-when-paused. #778
Conversation
Some details in this comment: cylc-doc/src/user-guide/interventions/index.rst Lines 48 to 55 in 8afb75d
Something I didn't mention there, but should have, is the terminal theme I used (Gnome - Tango Dark) for Tui recordings. |
3e73122
to
83ac08f
Compare
83ac08f
to
d1f2744
Compare
src/glossary.rst
Outdated
|
||
If a running task is held its running job is not affected, but it will | ||
not submit any more jobs (such as automatic :term:`retries <retry>`) | ||
until released. The children of held tasks are not automatically held. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get what you mean here (children = graph children), but I don't think users will.
We can omit this (there is no reason to think that this might happen):
until released. The children of held tasks are not automatically held. | |
until released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on graph children.
Less agreed on "there's no reason to think..." - I've had it several times from users who tried to "hold everything" by holding "all the tasks" - which doesn't hold everything because the children of any active tasks will carry on.
However, I'll take your suggestion.
Could also do with a quick entry in the changes section, we'll post this on Discourse, etc to advertise the change in behavior. |
Text review suggestions addressed. TODO:
|
Fixes,
Does not add stuff to the changes section to avoid conflict. |
Superseded by #790 |
Companion for
cylc/cylc-flow#6192cylc/cylc-flow#6499@oliver-sanders - I still need to update the intervention gif animation. Is it possible for you to advise on window size etc. so that I end up with a similar look to your originals, or do I just have to experiment with that?
TODO:
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.