Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs about using ROSE_DATAC #736

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Updated docs about using ROSE_DATAC #736

merged 9 commits into from
Jan 15, 2025

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented May 31, 2024 •
edited by MetRonnie
Loading

Companion of cylc/cylc-flow#6117

$CYLC_TASK_SHARE_CYCLE_DIR

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@wxtim wxtim marked this pull request as draft May 31, 2024 10:11
@wxtim wxtim mentioned this pull request May 31, 2024
Merged
8 tasks
@wxtim wxtim self-assigned this May 31, 2024
@wxtim wxtim added the small label May 31, 2024
@wxtim wxtim requested a review from oliver-sanders May 31, 2024 10:12
@wxtim wxtim added this to the 8.3.x milestone May 31, 2024
@wxtim wxtim marked this pull request as ready for review May 31, 2024 10:13
@oliver-sanders oliver-sanders changed the base branch from master to 8.3.x June 27, 2024 15:08
@oliver-sanders oliver-sanders changed the base branch from 8.3.x to master September 17, 2024 12:29
@oliver-sanders oliver-sanders modified the milestones: 8.3.x, 8.4.0 Sep 17, 2024
@oliver-sanders
Copy link
Member

(changed milestone and base branch to match pinned PR)

@oliver-sanders oliver-sanders modified the milestones: 8.4.0, 8.5.0 Dec 3, 2024
@wxtim wxtim requested a review from MetRonnie January 10, 2025 09:50
@wxtim
Updated docs about using ROSE_DATAC
8798b8a 
Update src/reference/job-script-vars/var-list.txt

Update src/workflow-design-guide/general-principles.rst

Co-authored-by: Ronnie Dutta <[email protected]>

Update src/reference/job-script-vars/var-list.txt

Co-authored-by: Ronnie Dutta <[email protected]>

response to review
@wxtim wxtim force-pushed the feature.CYLC_SHARE_CYCLE_DIR branch from 1cf2fe4 to 8798b8a Compare January 10, 2025 10:48
@wxtim wxtim requested a review from MetRonnie January 10, 2025 10:49
@MetRonnie MetRonnie mentioned this pull request Jan 10, 2025
Closed
1 task
@wxtim wxtim requested a review from MetRonnie January 10, 2025 13:04
MetRonnie
MetRonnie approved these changes Jan 14, 2025
View reviewed changes
src/reference/job-script-vars/var-list.txt Outdated Show resolved Hide resolved
oliver-sanders
oliver-sanders approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, accept or ignore.

src/reference/job-script-vars/var-list.txt Outdated Show resolved Hide resolved
@wxtim wxtim merged commit 33e3ed5 into cylc:master Jan 15, 2025
1 check passed
@wxtim wxtim deleted the feature.CYLC_SHARE_CYCLE_DIR branch January 15, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @oliver-sanders @MetRonnie