Stub #4
Merged
Stub #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed from src/recycle_version.h.in
fix reactor compilation
|
@jbae11 I don't know what I did, but I got it to work :) Actually I believe that circle-CI/recycle project need to be alive before a PR is issued to have the automatic hook working. |
|
ok actually I don't understand why this one don't trigger the test but #5 does :( |
|
might be because you where not in the cyclus group |
|
@bam241 interesting.. This PR is made by you too, right? what do you suggest we do from here? |
|
first accept the invitation to join CYclus group member. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything has been changed from
cycamore::xxxtorecycle::xxx.The Cycamore archetypes are not deleted (yet) to make sure tests work properly.
Thanks to @bam241 for great help.
To address issue #1 , an additional PR should be placed deleting all the cycamore archetypes,
which shouldn't be too hard.