Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter and move test data to testdata #3

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add linter and move test data to testdata #3

merged 1 commit into from
Apr 5, 2024

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented Apr 5, 2024

This PR:

  • sets up linter
  • moves test data from e2e to e2e/testdata, because testdata is an official directory name that Go ignores during test
  • reduces kind node count from 4 to 3, because I think it's enough
  • installs jq and yq (they will be used in the subsequent PRs)

Signed-off-by: Daichi Sakaue [email protected]

@yokaze yokaze self-assigned this Apr 5, 2024
@yokaze yokaze marked this pull request as ready for review April 5, 2024 01:34
@yokaze yokaze requested a review from chez-shanpu April 5, 2024 01:34
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit cbf7e66 into main Apr 5, 2024
1 check passed
@yokaze yokaze deleted the add-linter branch April 5, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants