Fix to check that egress_watcher pick a valid client #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terassyi
force-pushed
the
fix-to-check-valid-egress-client
branch
2 times, most recently
from
82689f9 to
5964c21
Compare
yokaze
requested changes
Mar 27, 2024
terassyi
force-pushed
the
fix-to-check-valid-egress-client
branch
from
5964c21 to
74d7700
Compare
ymmt2005
reviewed
Mar 29, 2024
terassyi
force-pushed
the
fix-to-check-valid-egress-client
branch
from
74d7700 to
fce5230
Compare
Signed-off-by: terasihma <[email protected]>
terassyi
force-pushed
the
fix-to-check-valid-egress-client
branch
from
fce5230 to
1955ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the fix for egress_watcher.
Egress_watcher will select only running pods as reconciliation targets.
And when multiple pods have the same address, egress_watcher will return an error.
Signed-off-by: terasihma [email protected]