Skip to content

Commit

Permalink
Add missing shift in CI image push script
Browse files Browse the repository at this point in the history
In the PR to add a UBI based image (#1927),
we added a new argument to the `tag_and_push` function in our Docker image
push step for CI. However, this addition neglected to shift the remaining
arguments. This lead the function to interpret the source image in the list of
image targets to push to, leading to a malformed image reference.
  • Loading branch information
micahlee committed Nov 10, 2020
1 parent d8740d4 commit 36b7e4f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions push-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,8 @@ function main() {

# tag_and_publish tag source image1 image2 ...
function tag_and_push() {
local tag="$1"
local source="$2"
shift
local tag="$1"; shift
local source="$1"; shift

for image in "$@"; do
local target=$image:$tag
Expand Down

0 comments on commit 36b7e4f

Please sign in to comment.