Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests due to chromium/badssl.com#501 #21

Merged
merged 1 commit into from
May 23, 2022
Merged

Fix failing tests due to chromium/badssl.com#501 #21

merged 1 commit into from
May 23, 2022

Conversation

szh
Copy link
Contributor

@szh szh commented May 20, 2022 •
edited
Loading

Desired Outcome

Fix SSL tests failing with SSLCertVerificationError

Implemented Changes

Connected Issue/Story

N/A

Definition of Done

  • Unit tests pass

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this May 20, 2022
@szh szh changed the title Fix failing tests due to https://github.com/chromium/badssl.com/issues/501 Fix failing tests due tochromium/badssl.com#501 May 20, 2022
@szh szh changed the title Fix failing tests due tochromium/badssl.com#501 Fix failing tests due to chromium/badssl.com#501 May 20, 2022
@szh szh marked this pull request as ready for review May 20, 2022 18:34
@szh szh requested a review from a team as a code owner May 20, 2022 18:34
jtuttle
jtuttle reviewed May 20, 2022
View reviewed changes
tests/https/test_unit_http_ssl.py
# These are temporarily broken, see https://github.com/chromium/badssl.com/issues/501
# "https://sha384.badssl.com",
# "https://sha512.badssl.com",
"https://tls-v1-2.badssl.com",
Copy link
Member

@jtuttle jtuttle May 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried loading this and my browser is reporting a secure connection. Is that correct? I would have assumed this site is intended to provide a site with well....bad SSL. :)

Copy link
Contributor Author

@szh szh May 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For https://tls-v1-2.badssl.com? Yes, that's supposed to be valid.
You can see here which are supposed to be green.

jtuttle
jtuttle approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@jtuttle jtuttle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the uncommented URL works

@szh szh merged commit 6a5f738 into main May 23, 2022
@szh szh deleted the fix-ssl-tests branch May 23, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtuttle jtuttle jtuttle approved these changes

Assignees

@szh szh

Labels
kind/failing-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szh @jtuttle