pre-commit: Keep prettier version in sync; add eslint fixer #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/use-local-prettier
branch
3 times, most recently
from
702b7e1 to
43827d3
Compare
pokey
force-pushed
the
pokey/use-local-prettier
branch
2 times, most recently
from
4c34a82 to
9e15a51
Compare
pokey
commented
Apr 8, 2023
| @@ -40,7 +40,8 @@ | |||
| }, | |||
| "pnpm": { | |||
| "patchedDependencies": { | |||
| "@docusaurus/[email protected]": "patches/@[email protected]" | |||
| "@docusaurus/[email protected]": "patches/@[email protected]", | |||
| "@pnpm/[email protected]": "patches/@[email protected]" | |||
There was a problem hiding this comment.
Patching until pnpm/meta-updater#10 is fixed
pokey
force-pushed
the
pokey/use-local-prettier
branch
4 times, most recently
from
178d7a8 to
0a3d08d
Compare
pokey
force-pushed
the
pokey/use-local-prettier
branch
from
0a3d08d to
5a937c6
Compare
pokey
changed the title
pokey
changed the title
pokey
changed the title
pokey
force-pushed
the
pokey/use-local-prettier
branch
from
6ff801b to
5a937c6
Compare
pokey
changed the title
pokey
changed the title
for more information, see https://pre-commit.ci
auscompgeek
reviewed
Apr 9, 2023
.pre-commit-config.yaml
Outdated
| language: node | ||
| entry: prettier --write --list-different --ignore-unknown | ||
| additional_dependencies: | ||
| - [email protected] |
There was a problem hiding this comment.
Why not use the technique here? https://github.com/pre-commit/mirrors-prettier/issues/29#issuecomment-1332667344
|
Just realised that we could prob avoid all this nonsense by just doing pre-commit fixing in a GitHub action rather than in pre-commit.ci. Then we could just start with a pnpm install and run local scripts using |
|
Indeed. If you still want autofix commits, you can use pre-commit.ci lite: https://pre-commit.ci/lite.html |
auscompgeek
reviewed
Apr 9, 2023
pokey
changed the title
7 tasks
|
Closing in favour of #1404 |
pokey
added a commit
that referenced
this pull request
Apr 11, 2023
- Partially addresses #640 - Supercedes #1400 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet - [x] Disable pre-commit.ci - [x] Disable pre-commit.ci lite - [ ] Change branch protection rules - [ ] Check boxes in #640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist