wip

cunla · Dec 24, 2024 · 3c39ab0 · 3c39ab0
1 parent c07c998
commit 3c39ab0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/fakeredis/_msgs.py b/fakeredis/_msgs.py
@@ -125,6 +125,7 @@
 
 NO_PERMISSION_ERROR = "NOPERM User {} has no permissions to run the '{}' command"
 NO_PERMISSION_KEY_ERROR = "NOPERM No permissions to access a key"
+NO_PERMISSION_CHANNEL_ERROR = "NOPERM No permissions to access a channel"
 
 # Command flags
 FLAG_NO_SCRIPT = "s"  # Command not allowed in scripts

diff --git a/fakeredis/model/_acl.py b/fakeredis/model/_acl.py
@@ -358,8 +358,8 @@ def validate_command(self, username: bytes, client_info: bytes, fields: List[byt
         if len(keys_not_allowed) > 0:
             self.add_log_record(b"key", b"toplevel", keys_not_allowed[0], username, client_info)
             raise SimpleError(msgs.NO_PERMISSION_KEY_ERROR)
-        if "@pubsub" in command_info[6]:
+        if b"@pubsub" in command_info[6]:
             channels_not_allowed = user_acl.channels_not_allowed(command_info, fields)
             if len(channels_not_allowed) > 0:
-                self.add_log_record(b"key", b"toplevel", keys_not_allowed[0], username, client_info)
-                raise SimpleError(msgs.NO_PERMISSION_KEY_ERROR)
+                self.add_log_record(b"channel", b"toplevel", channels_not_allowed[0], username, client_info)
+                raise SimpleError(msgs.NO_PERMISSION_CHANNEL_ERROR)