Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor CURP handling across multiple resources to use the updated C…
Browse files Browse the repository at this point in the history
…urp type instead of CurpField
gabino committed Jan 17, 2025
1 parent 4caef3d commit c25b916
Showing 6 changed files with 18 additions and 18 deletions.
10 changes: 5 additions & 5 deletions cuenca/resources/curp_validations.py
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
Gender,
State,
)
from cuenca_validations.types.identities import CurpField
from cuenca_validations.types.identities import Curp
from pydantic import ConfigDict, Field

from ..http import Session, session as global_session
@@ -36,13 +36,13 @@ class CurpValidation(Creatable, Retrievable):
nationality: Optional[Country] = Field(
None, description='In format ISO 3166 Alpha-2'
)
manual_curp: Optional[CurpField] = Field(
manual_curp: Optional[Curp] = Field(
None, description='curp provided in request'
)
calculated_curp: CurpField = Field(
calculated_curp: Curp = Field(
description='Calculated CURP based on request data'
)
validated_curp: Optional[CurpField] = Field(
validated_curp: Optional[Curp] = Field(
None, description='CURP validated in Renapo, null if not exists'
)
renapo_curp_match: bool = Field(
@@ -84,7 +84,7 @@ def create(
state_of_birth: Optional[State] = None,
gender: Optional[Gender] = None,
second_surname: Optional[str] = None,
manual_curp: Optional[CurpField] = None,
manual_curp: Optional[Curp] = None,
*,
session: Session = global_session,
) -> 'CurpValidation':
4 changes: 2 additions & 2 deletions cuenca/resources/identities.py
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@
UserStatus,
VerificationStatus,
)
from cuenca_validations.types.identities import CurpField
from cuenca_validations.types.identities import Curp

from .base import Queryable, Retrievable

@@ -24,7 +24,7 @@ class Identity(Retrievable, Queryable):
names: str
first_surname: str
second_surname: Optional[str] = None
curp: Optional[CurpField] = None
curp: Optional[Curp] = None
rfc: Optional[str] = None
gender: Gender
date_of_birth: Optional[dt.date] = None
6 changes: 3 additions & 3 deletions cuenca/resources/kyc_verifications.py
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@

from cuenca_validations.types import (
Address,
CurpField,
Curp,
KYCVerificationUpdateRequest,
Rfc,
)
@@ -20,7 +20,7 @@ class KYCVerification(Creatable, Retrievable, Updateable):
created_at: dt.datetime
deactivated_at: Optional[dt.datetime] = None
verification_id: Optional[str] = None
curp: Optional[CurpField] = None
curp: Optional[Curp] = None
rfc: Optional[Rfc] = None
address: Optional[Address] = None

@@ -47,7 +47,7 @@ def create(cls, session: Session = global_session) -> 'KYCVerification':
def update(
cls,
kyc_id: str,
curp: CurpField,
curp: Curp,
) -> 'KYCVerification':
req = KYCVerificationUpdateRequest(curp=curp)
return cls._update(id=kyc_id, **req.model_dump())
6 changes: 3 additions & 3 deletions cuenca/resources/limited_wallets.py
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
from clabe import Clabe
from cuenca_validations.types import (
AccountQuery,
CurpField,
Curp,
LimitedWalletRequest,
Rfc,
)
@@ -16,12 +16,12 @@ class LimitedWallet(Wallet):
_query_params: ClassVar = AccountQuery
account_number: Clabe
allowed_rfc: Optional[Rfc] = None
allowed_curp: CurpField
allowed_curp: Curp

@classmethod
def create(
cls,
allowed_curp: CurpField,
allowed_curp: Curp,
allowed_rfc: Optional[Rfc] = None,
) -> 'LimitedWallet':
"""
6 changes: 3 additions & 3 deletions cuenca/resources/user_lists_validation.py
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
from typing import ClassVar, Optional

from cuenca_validations.types import UserListsRequest, VerificationStatus
from cuenca_validations.types.identities import CurpField
from cuenca_validations.types.identities import Curp

from ..http import Session, session as global_session
from .base import Creatable, Retrievable
@@ -14,7 +14,7 @@ class UserListsValidation(Creatable, Retrievable):
names: Optional[str] = None
first_surname: Optional[str] = None
second_surname: Optional[str] = None
curp: Optional[CurpField] = None
curp: Optional[Curp] = None
account_number: Optional[str] = None
status: Optional[VerificationStatus] = None

@@ -24,7 +24,7 @@ def create(
names: Optional[str] = None,
first_surname: Optional[str] = None,
second_surname: Optional[str] = None,
curp: Optional[CurpField] = None,
curp: Optional[Curp] = None,
account_number: Optional[str] = None,
*,
session: Session = global_session,
4 changes: 2 additions & 2 deletions cuenca/resources/users.py
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
UserUpdateRequest,
)
from cuenca_validations.types.enums import Country, Gender, State
from cuenca_validations.types.identities import CurpField
from cuenca_validations.types.identities import Curp
from pydantic import ConfigDict, EmailStr, Field, HttpUrl

from ..http import Session, session as global_session
@@ -103,7 +103,7 @@ def balance(self) -> int:
@classmethod
def create(
cls,
curp: CurpField,
curp: Curp,
id: Optional[str] = None,
phone_number: Optional[PhoneNumber] = None,
email_address: Optional[EmailStr] = None,

0 comments on commit c25b916

Please sign in to comment.