Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Implement format and col_description #9072

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Addresses #8926

Description of Changes Made (if issue reference is not provided)

Adds format function, only %I placeholder implemented
Adds col_description stub implementation, always return empty string
Add stub for regclass casting of schema qualified type names, always returns 0
Picked up from #8947

@mcheshkov mcheshkov force-pushed the format-col-description-metabase-sync branch 4 times, most recently from 21c4fc7 to 267f382 Compare January 8, 2025 21:24
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 86.94030% with 35 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (8f0758e) to head (58c72f5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/udf/common.rs 74.63% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9072      +/-   ##
==========================================
+ Coverage   83.14%   83.16%   +0.02%     
==========================================
  Files         225      225              
  Lines       80296    80553     +257     
==========================================
+ Hits        66759    66992     +233     
- Misses      13537    13561      +24     
Flag Coverage Δ
cubesql 83.16% <86.94%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review January 9, 2025 02:22
@mcheshkov mcheshkov requested a review from a team as a code owner January 9, 2025 02:22
@mcheshkov mcheshkov force-pushed the format-col-description-metabase-sync branch 2 times, most recently from 3a1c40e to e47d3b7 Compare January 14, 2025 19:33
@mcheshkov mcheshkov force-pushed the format-col-description-metabase-sync branch from e47d3b7 to d7491ec Compare January 16, 2025 13:48
@mcheshkov mcheshkov force-pushed the format-col-description-metabase-sync branch from d7491ec to 58c72f5 Compare January 16, 2025 21:58
@mcheshkov mcheshkov merged commit bde6eea into master Jan 16, 2025
68 checks passed
@mcheshkov mcheshkov deleted the format-col-description-metabase-sync branch January 16, 2025 22:51
@adamfeldman
Copy link

Is there any anticipation on the next Cube release which will include this work?

@mcheshkov
Copy link
Member Author

@adamfeldman 1.1.16 just released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants