-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cubesql): Implement format and col_description #9072
Conversation
21c4fc7
to
267f382
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9072 +/- ##
==========================================
+ Coverage 83.14% 83.16% +0.02%
==========================================
Files 225 225
Lines 80296 80553 +257
==========================================
+ Hits 66759 66992 +233
- Misses 13537 13561 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3a1c40e
to
e47d3b7
Compare
e47d3b7
to
d7491ec
Compare
d7491ec
to
58c72f5
Compare
Is there any anticipation on the next Cube release which will include this work? |
@adamfeldman 1.1.16 just released |
Check List
Issue Reference this PR resolves
Addresses #8926
Description of Changes Made (if issue reference is not provided)
Adds
format
function, only%I
placeholder implementedAdds
col_description
stub implementation, always return empty stringAdd stub for regclass casting of schema qualified type names, always returns 0
Picked up from #8947