Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for resizing on Kubernetes 1.32 #37

Merged
merged 2 commits into from
Jan 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

- name: Install protoc-gen-go
run: |
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.31
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.36.3
go install github.com/containerd/ttrpc/cmd/[email protected]

- uses: awalsh128/cache-apt-pkgs-action@v1
Expand Down
3 changes: 2 additions & 1 deletion activator/activator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"io"
"log/slog"
"net"
"net/http"
"net/http/httptest"
Expand Down Expand Up @@ -31,7 +32,7 @@ func TestActivator(t *testing.T) {
s, err := NewServer(ctx, nn)
require.NoError(t, err)

bpf, err := InitBPF(os.Getpid())
bpf, err := InitBPF(os.Getpid(), slog.Default())
require.NoError(t, err)
require.NoError(t, bpf.AttachRedirector("lo"))

Expand Down
7 changes: 4 additions & 3 deletions activator/bpf.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ type BPF struct {
objs *bpfObjects
qdiscs []*netlink.GenericQdisc
filters []*netlink.BpfFilter
log *slog.Logger
}

func InitBPF(pid int) (*BPF, error) {
func InitBPF(pid int, log *slog.Logger) (*BPF, error) {
// Allow the current process to lock memory for eBPF resources.
if err := rlimit.RemoveMemlock(); err != nil {
return nil, err
Expand All @@ -49,7 +50,7 @@ func InitBPF(pid int) (*BPF, error) {
return nil, fmt.Errorf("loading objects: %w", err)
}

return &BPF{pid: pid, objs: &objs}, nil
return &BPF{pid: pid, log: log, objs: &objs}, nil
}

func (bpf *BPF) Cleanup() error {
Expand All @@ -68,7 +69,7 @@ func (bpf *BPF) Cleanup() error {
}
}

slog.Info("deleting", "path", PinPath(bpf.pid))
bpf.log.Info("deleting", "path", PinPath(bpf.pid))
return os.RemoveAll(PinPath(bpf.pid))
}

Expand Down
159 changes: 41 additions & 118 deletions api/shim/v1/shim.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 9 additions & 7 deletions cmd/manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ var (
func main() {
flag.Parse()

opts := &slog.HandlerOptions{}
if *debug {
slog.SetLogLoggerLevel(slog.LevelDebug)
opts.Level = slog.LevelDebug
}
slog.Info("starting manager", "metrics-addr", *metricsAddr)
log := slog.New(slog.NewJSONHandler(os.Stdout, opts))
log.Info("starting manager", "metrics-addr", *metricsAddr)

ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
defer stop()

if err := manager.AttachRedirectors(ctx); err != nil {
slog.Error("attaching redirectors", "err", err)
if err := manager.AttachRedirectors(ctx, log); err != nil {
log.Error("attaching redirectors", "err", err)
os.Exit(1)
}

Expand All @@ -46,13 +48,13 @@ func main() {

podHandlers := []manager.PodHandler{}
if *statusLabels {
podHandlers = append(podHandlers, manager.NewPodLabeller())
podHandlers = append(podHandlers, manager.NewPodLabeller(log))
}
if *inPlaceScaling {
podHandlers = append(podHandlers, manager.NewPodScaler())
podHandlers = append(podHandlers, manager.NewPodScaler(log))
}

if err := manager.StartSubscribers(ctx, podHandlers...); err != nil {
if err := manager.StartSubscribers(ctx, log, podHandlers...); err != nil {
slog.Error("starting subscribers", "err", err)
os.Exit(1)
}
Expand Down
1 change: 1 addition & 0 deletions config/pod-updater/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ rules:
- ""
resources:
- pods
- pods/resize
verbs:
- get
- update
Expand Down
2 changes: 2 additions & 0 deletions e2e/kind.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
featureGates:
InPlacePodVerticalScaling: true
InPlacePodVerticalScalingAllocatedStatus: true
nodes:
- role: control-plane
image: kindest/node:v1.32.0@sha256:c48c62eac5da28cdadcf560d1d8616cfa6783b58f0d94cf63ad1bf49600cb027
extraMounts:
- hostPath: /proc
containerPath: /host/proc
Expand Down
Loading
Loading