Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always retry when port detection fails #30

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix: always retry when port detection fails #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions zeropod/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,10 @@ func (c *Container) startActivator(ctx context.Context) error {
log.G(ctx).Info("no ports defined in config, detecting listening ports")
// if no ports are specified in the config, we try to find all listening ports
ports, err := listeningPortsDeep(c.initialProcess.Pid())
if err != nil {
return err
}

if len(ports) == 0 {
if err != nil || len(ports) == 0 {
// our initialProcess might not even be running yet, so finding the listening
// ports might fail in various ways. We return errNoPortsDetected so the
// caller can retry later.
return errNoPortsDetected
}

Expand Down
Loading