Implement in-place pod request scaling #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of serving the metrics over HTTP, we now use ttrpc and implement a more generic "shim service" that can be used for different purposes than just metrics.
the shim ttrpc service now exposes a SubscribeStatus function which the manager subscribes to for receiving zeropod status updates, such as when checkpointing and restoring.
If enabled, we make use of the (still alpha) feature gate InPlacePodVerticalScaling to change the pod requests to a minimum on scaling down and increasing them to the original value on restore. This has been marked as experimental and also needs to be enabled by setting a flag on the manager and of course the feature flag needs to be enabled.
ctrox
force-pushed
the
resource-requests
branch
2 times, most recently
from
9552aae to
3eb988c
Compare
This adds a kustomize component to enable to in-place-scaling feature on demand. It is enabled by default for the kind overlay for local and e2e testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If enabled, we make use of the (still alpha) feature gate InPlacePodVerticalScaling to change the pod requests to a minimum on scaling down and increasing them to the original value on restore. This has been marked as experimental and also needs to be enabled by setting a flag on the manager and of course the feature flag needs to be enabled.
TODO: