Remove most of protected members

ctidigital · Jan 31, 2018 · fb2dbeb · fb2dbeb
1 parent 3a9eba3
commit fb2dbeb
Show file tree

Hide file tree

Showing 17 changed files with 149 additions and 153 deletions.
diff --git a/Adapter/Algolia.php b/Adapter/Algolia.php
@@ -23,10 +23,10 @@
 class Algolia implements AdapterInterface
 {
     /** @var Mapper */
-    protected $mapper;
+    private $mapper;
 
     /** @var ResponseFactory */
-    protected $responseFactory;
+    private $responseFactory;
 
     /** @var ResourceConnection */
     private $resource;
@@ -38,22 +38,22 @@ class Algolia implements AdapterInterface
     private $temporaryStorageFactory;
 
     /** @var ConfigHelper */
-    protected $config;
+    private $config;
 
     /** @var Data */
-    protected $catalogSearchHelper;
+    private $catalogSearchHelper;
 
     /** @var StoreManagerInterface */
-    protected $storeManager;
+    private $storeManager;
 
     /** @var AlgoliaHelper */
-    protected $algoliaHelper;
+    private $algoliaHelper;
 
     /** @var Http */
-    protected $request;
+    private $request;
 
     /** @var DocumentFactory */
-    protected $documentFactory;
+    private $documentFactory;
 
     /**
      * @param Mapper $mapper

diff --git a/Block/Algolia.php b/Block/Algolia.php
@@ -20,21 +20,21 @@
 
 class Algolia extends Template implements CollectionDataSourceInterface
 {
-    protected $config;
-    protected $catalogSearchHelper;
-    protected $storeManager;
-    protected $objectManager;
-    protected $registry;
-    protected $productHelper;
-    protected $currency;
-    protected $algoliaHelper;
-    protected $urlHelper;
-    protected $formKey;
-    protected $httpContext;
-    protected $coreHelper;
-    protected $categoryHelper;
-
-    protected $priceKey;
+    private $config;
+    private $catalogSearchHelper;
+    private $storeManager;
+    private $objectManager;
+    private $registry;
+    private $productHelper;
+    private $currency;
+    private $algoliaHelper;
+    private $urlHelper;
+    private $formKey;
+    private $httpContext;
+    private $coreHelper;
+    private $categoryHelper;
+
+    private $priceKey;
 
     public function __construct(
         Template\Context $context,

diff --git a/Block/Instant/Hit.php b/Block/Instant/Hit.php
@@ -9,9 +9,9 @@
 
 class Hit extends Template
 {
-    protected $config;
-    protected $priceKey;
-    protected $httpContext;
+    private $config;
+    private $priceKey;
+    private $httpContext;
 
     public function __construct(
         Template\Context $context,

diff --git a/Block/Instant/Wrapper.php b/Block/Instant/Wrapper.php
@@ -7,7 +7,7 @@
 
 class Wrapper extends Template
 {
-    protected $config;
+    private $config;
 
     public function __construct(
         Template\Context $context,

diff --git a/Block/TopSearch.php b/Block/TopSearch.php
@@ -9,8 +9,8 @@
 
 class TopSearch extends Template implements CollectionDataSourceInterface
 {
-    protected $config;
-    protected $catalogSearchHelper;
+    private $config;
+    private $catalogSearchHelper;
 
     public function __construct(
         Template\Context $context,

diff --git a/Controller/View/Index.php b/Controller/View/Index.php
@@ -9,7 +9,7 @@
 class Index extends Action
 {
     /** @var \Magento\Framework\View\Result\PageFactory */
-    protected $resultPageFactory;
+    private $resultPageFactory;
 
     public function __construct(
         Context $context,

diff --git a/Helper/AlgoliaHelper.php b/Helper/AlgoliaHelper.php
@@ -13,22 +13,22 @@
 class AlgoliaHelper extends AbstractHelper
 {
     /** @var Client */
-    protected $client;
+    private $client;
 
     /** @var ConfigHelper */
-    protected $config;
+    private $config;
 
     /** @var ManagerInterface */
-    protected $messageManager;
+    private $messageManager;
 
     /** @var ConsoleOutput */
-    protected $consoleOutput;
+    private $consoleOutput;
 
     /** @var int */
-    protected $maxRecordSize = 20000;
+    private $maxRecordSize = 20000;
 
     /** @var array */
-    protected $potentiallyLongAttributes = ['description', 'short_description', 'meta_description', 'content'];
+    private $potentiallyLongAttributes = ['description', 'short_description', 'meta_description', 'content'];
 
     /** @var string */
     private static $lastUsedIndexName;

diff --git a/Helper/ConfigHelper.php b/Helper/ConfigHelper.php
@@ -99,8 +99,6 @@ class ConfigHelper
     const EXTRA_SETTINGS_ADDITIONAL_SECTIONS =
         'algoliasearch_extra_settings/extra_settings/additional_sections_extra_settings';
 
-    protected $_productTypeMap = [];
-
     private $configInterface;
     private $objectManager;
     private $currency;

diff --git a/Helper/Data.php b/Helper/Data.php
@@ -24,21 +24,21 @@ class Data
 {
     const COLLECTION_PAGE_SIZE = 100;
 
-    protected $algoliaHelper;
-
-    protected $pageHelper;
-    protected $categoryHelper;
-    protected $productHelper;
-    protected $suggestionHelper;
-    protected $additionalSectionHelper;
-    protected $stockRegistry;
-
-    protected $logger;
-    protected $configHelper;
-    protected $emulation;
-    protected $resource;
-    protected $eventManager;
-    protected $storeManager;
+    private $algoliaHelper;
+
+    private $pageHelper;
+    private $categoryHelper;
+    private $productHelper;
+    private $suggestionHelper;
+    private $additionalSectionHelper;
+    private $stockRegistry;
+
+    private $logger;
+    private $configHelper;
+    private $emulation;
+    private $resource;
+    private $eventManager;
+    private $storeManager;
 
     private $emulationRuns = false;
 
@@ -448,7 +448,7 @@ public function rebuildStoreCategoryIndexPage($storeId, $collectionDefault, $pag
         unset($collection);
     }
 
-    protected function getProductsRecords($storeId, $collection, $potentiallyDeletedProductsIds = null)
+    private function getProductsRecords($storeId, $collection, $potentiallyDeletedProductsIds = null)
     {
         $productsToIndex = [];
         $productsToRemove = [];